[GitHub] [airflow] dstandish commented on a diff in pull request #26509: Fix airflow tasks run --local when dags_folder differs from that of processor

Thu, 22 Sep 2022 10:07:08 -0700 


dstandish commented on code in PR #26509:
URL: https://github.com/apache/airflow/pull/26509#discussion_r977899429


##########
airflow/models/dag.py:
##########
@@ -1189,11 +1195,25 @@ def relative_fileloc(self) -> pathlib.Path:
         """File location of the importable dag 'file' relative to the 
configured DAGs folder."""
         path = pathlib.Path(self.fileloc)
         try:
-            return path.relative_to(settings.DAGS_FOLDER)
+            rel_path = path.relative_to(self.dag_processor_dags_folder or 
settings.DAGS_FOLDER)
+            if rel_path == pathlib.Path('.'):
+                return path
+            else:
+                return rel_path
         except ValueError:
             # Not relative to DAGS_FOLDER.
             return path
 
+    @property
+    def dag_processor_dags_folder(self):

Review Comment:
   ah i guess you would know better than most ;) 
   <img width="679" alt="image" 
src="https://user-images.githubusercontent.com/15932138/191809049-5b553a1a-d0b5-41e4-9dcc-7182ee21a127.png";>
   let me know your thoughts



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to