potiuk commented on code in PR #26612:
URL: https://github.com/apache/airflow/pull/26612#discussion_r978372140
##########
dev/breeze/src/airflow_breeze/params/shell_params.py:
##########
@@ -173,15 +174,18 @@ def print_badge_info(self):
get_console().print(f'[info]Backend: {self.backend}
{self.backend_version}[/]')
get_console().print(f'[info]Airflow used at runtime:
{self.use_airflow_version}[/]')
- def get_backend_compose_files(self, backend: str):
+ def get_backend_compose_files(self, backend: str) -> list[str]:
backend_docker_compose_file =
f"{str(SCRIPTS_CI_DIR)}/docker-compose/backend-{backend}.yml"
backend_port_docker_compose_file =
f"{str(SCRIPTS_CI_DIR)}/docker-compose/backend-{backend}-port.yml"
- return backend_docker_compose_file, backend_port_docker_compose_file
+ if backend == 'sqlite' or not self.forward_ports:
Review Comment:
Here (and few lines below) @bowrna I check if "sefl.forward_ports" is set to
True - and only there I also include `-port.yml` files. Effectively all the
`docker-compose` used by parallel tests do not forward the ports from host so
the prblem with busy port is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
