collinmcnulty commented on code in PR #26582:
URL: https://github.com/apache/airflow/pull/26582#discussion_r979063465
##########
airflow/executors/kubernetes_executor.py:
##########
@@ -548,11 +548,11 @@ def execute_async(
executor_config: Any | None = None,
) -> None:
"""Executes task asynchronously"""
- self.log.info('Add task %s with command %s with executor_config %s',
key, command, executor_config)
Review Comment:
Can we add the executor_config at the debug level at least? There are cases
where you want to see the config that aren't full-on invalid.
##########
airflow/executors/kubernetes_executor.py:
##########
@@ -302,7 +302,6 @@ def run_next(self, next_job: KubernetesJobType) -> None:
status
"""
key, command, kube_executor_config, pod_template_file = next_job
- self.log.info('Kubernetes job is %s', key)
Review Comment:
I like the new line 335. LGTM
##########
airflow/executors/kubernetes_executor.py:
##########
@@ -380,7 +380,7 @@ def sync(self) -> None:
def process_watcher_task(self, task: KubernetesWatchType) -> None:
"""Process the task by watcher."""
pod_id, namespace, state, annotations, resource_version = task
- self.log.info(
Review Comment:
I prefer this at info level as it let's you know when the pod finished to
complement knowing when it started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
