hterik commented on code in PR #26582:
URL: https://github.com/apache/airflow/pull/26582#discussion_r979280673
##########
airflow/executors/kubernetes_executor.py:
##########
@@ -548,11 +548,11 @@ def execute_async(
executor_config: Any | None = None,
) -> None:
"""Executes task asynchronously"""
- self.log.info('Add task %s with command %s with executor_config %s',
key, command, executor_config)
Review Comment:
Fair enough, though if something is invalid it would fail and be logged in
the exception block below? Bad pods would also be logged on line 270 once
create_namespaced_pod fails.
Anyway, I will restore it but change to debug.
##########
airflow/executors/kubernetes_executor.py:
##########
@@ -380,7 +380,7 @@ def sync(self) -> None:
def process_watcher_task(self, task: KubernetesWatchType) -> None:
"""Process the task by watcher."""
pod_id, namespace, state, annotations, resource_version = task
- self.log.info(
Review Comment:
The exact same thing is being logged again once the item is popped from the
`result_queue` on line 598. (added to queue on line 398 right below here)
IMO the path from here to there is internal to this module and hence only
deserves debug-level.
btw, the `if key` on line 387 looks redundant, can `annotations_to_key` ever
return None?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
