Taragolis commented on code in PR #26269:
URL: https://github.com/apache/airflow/pull/26269#discussion_r980510218
##########
airflow/providers/amazon/aws/hooks/glue.py:
##########
@@ -202,34 +204,52 @@ def job_completion(self, job_name: str, run_id: str,
verbose: bool = False) -> D
failed_states = ['FAILED', 'TIMEOUT']
finished_states = ['SUCCEEDED', 'STOPPED']
next_log_token = None
- job_failed = False
+ glue_client = self.get_conn()
+ cw_logs = AwsLogsHook()
Review Comment:
Without any parameters to the hook it will use default boto3 strategy, and
`cw_logs.get_conn()` turned into `boto3.client("logs")`.
```suggestion
cw_logs = AwsLogsHook(aws_conn_id=self.aws_conn_id,
region_name=self.region_name)
```
But it really nice that you move code related to AWS CloudWatch to the
`AwsLogsHook`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
