Taragolis commented on code in PR #26374:
URL: https://github.com/apache/airflow/pull/26374#discussion_r981304880
##########
airflow/providers/slack/transfers/sql_to_slack.py:
##########
@@ -165,3 +193,115 @@ def execute(self, context: Context) -> None:
self._render_and_send_slack_message(context, df)
self.log.debug('Finished sending SQL data to Slack')
+
+
+class SqlToSlackApiFileOperator(BaseSqlToSlackOperator):
Review Comment:
I think we do not need to rush especially if we do not have agreement how to
do it in a better way.
IMHO. For send SQL response as a message we could actually do by three
different way without turn into the pain 🤣
most of the major parameters are presented in all 3 APIs requests.
For files situation are different we can use only Slack API and internally
it do not have same parameters from different methods. Most close it `text`
from `chat.postMessage` and `initial_comment` from `files.upload` even
`channel` and `channels` working differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
