pierrejeambrun commented on code in PR #26457: URL: https://github.com/apache/airflow/pull/26457#discussion_r982806904
########## airflow/www/static/js/api/useSetTaskInstanceNotes.ts: ########## @@ -0,0 +1,107 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import axios from 'axios'; +import { useMutation, useQueryClient } from 'react-query'; +import { getMetaValue, getTask } from 'src/utils'; +import type { GridData } from 'src/api/useGridData'; +import { emptyGridData } from 'src/api/useGridData'; +import type { API } from 'src/types'; +import useErrorToast from '../utils/useErrorToast'; + +const setTaskInstancesNotesURI = getMetaValue('set_task_instance_note'); + +export default function useSetTaskInstanceNotes( + dagId: string, + runId: string, + taskId: string, + mapIndex: number, + newNotesValue: string, +) { + const queryClient = useQueryClient(); + const errorToast = useErrorToast(); + // Note: Werkzeug does not like the META URL with an integer. It can not put _MAP_INDEX_ there Review Comment: cf my comment to maybe try to avoid this, and `useTaskInstance` handle this same scenario. (maybe not in the best way but might be worth to take a look) **edit:** The comment I am referring to never made it through apparently :). For the `get_task_instance` and `get_mapped_task_instance`, we have the same problem. What we do is that we pass the trailing `/map_index` for mapped task, so the map_index is defined and >=0. For unmapped task we just request without the trailing map index, such as: - /dags/{dag_id}/dagRuns/{dag_run_id}/taskInstances/{task_id} -> for unmapped task - /dags/{dag_id}/dagRuns/{dag_run_id}/taskInstances/{task_id}/{map_index} -> for mapped tasks This way we never pass -1 in the path. This is for a GET method where passing it in a body would be quite an unconventional choice :joy:, we have more freedom here. But maybe this forces us to have 2 entries in the spec... one for mapped and one for unmapped... which doesn't seem great -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
