pierrejeambrun commented on code in PR #26457:
URL: https://github.com/apache/airflow/pull/26457#discussion_r982795577
##########
airflow/models/dagrun.py:
##########
@@ -119,6 +119,7 @@ class DagRun(Base, LoggingMixin):
# When a scheduler last attempted to schedule TIs for this DagRun
last_scheduling_decision = Column(UtcDateTime)
dag_hash = Column(String(32))
+ notes = Column(String(1000))
Review Comment:
nit: `notes` as a plural made me think at first sight that it would be a `1
to N` relationship i.e multiple notes per entity (TI or DagRun). Maybe that's
just me but I feel like choosing the singular `note` would avoid any confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
