o-nikolas commented on code in PR #26946:
URL: https://github.com/apache/airflow/pull/26946#discussion_r992932136
##########
airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -125,7 +125,13 @@ def create_session(self) -> boto3.session.Session:
return boto3.session.Session(region_name=self.region_name)
elif not self.role_arn:
return self.basic_session
- return
self._create_session_with_assume_role(session_kwargs=self.conn.session_kwargs)
+ # Values stored in AwsConnectionWrapper.session_kwargs intend to use
only create initial boto3 session
+ # If user want to use 'assume_role' mechanism we need provide only
'region_name'
+ # otherwise other parameters might conflict with base botocore session.
+ assume_session_kwargs = {}
+ if self.conn.region_name:
+ assume_session_kwargs["region_name"] = self.conn.region_name
Review Comment:
Hmm, okay, I don't really like codifying assumptions against a non-public
API, but this seems like a valuable fix if you're seeing issues with the
current implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
