mingjie-li opened a new pull request #5494: [AIRFLOW-4856] change hard coded 
run_as_user to an option in config file
URL: https://github.com/apache/airflow/pull/5494
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following 
[AIRFLOW-4856](https://issues.apache.org/jira/browse/AIRFLOW-4856) issues and 
references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-4856
   
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   when using KubernetesExecutor with git_sync, an init container will be 
created to sync with the git repo, the init container has a security context 
with hard coded runAsUser=65533, this pull request aim to change the hard coded 
value to a config option
   
   ### Tests
   
   - [x] My PR adds the following unit tests:
     * create test_init_environment_using_git_sync_run_as_user_empty: when the 
option is empty, not security context should be created
     * update test_worker_git_dags to check the value of the option has been 
correctly added to security context
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
     - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to