ferruzzi commented on code in PR #26652:
URL: https://github.com/apache/airflow/pull/26652#discussion_r1000998568
##########
airflow/providers/amazon/aws/operators/glacier.py:
##########
@@ -54,3 +54,55 @@ def __init__(
def execute(self, context: Context):
hook = GlacierHook(aws_conn_id=self.aws_conn_id)
return hook.retrieve_inventory(vault_name=self.vault_name)
+
+
+class GlacierUploadArchiveOperator(BaseOperator):
+ """
+ This operation adds an archive to a vault
Review Comment:
```suggestion
This operator adds an archive to an Amazon S3 Glacier vault
```
##########
airflow/providers/amazon/aws/operators/glacier.py:
##########
@@ -54,3 +54,55 @@ def __init__(
def execute(self, context: Context):
hook = GlacierHook(aws_conn_id=self.aws_conn_id)
return hook.retrieve_inventory(vault_name=self.vault_name)
+
+
+class GlacierUploadArchiveOperator(BaseOperator):
+ """
+ This operation adds an archive to a vault
+
+ .. seealso::
+ For more information on how to use this operator, take a look at the
guide:
+ :ref:`howto/operator:GlacierUploadArchiveOperator`
+
+ :param account_id: The AWS account ID of the account that owns the vault.
+ You can either specify an AWS account ID or optionally a single `-`
(hyphen),
+ in which case Amazon S3 Glacier uses the AWS account ID associated with
+ the credentials used to sign the request
Review Comment:
```suggestion
:param account_id: Optional AWS account ID of the account that owns the
vault. Defaults to the credentials used to sign the request
```
##########
airflow/providers/amazon/aws/operators/glacier.py:
##########
@@ -54,3 +54,55 @@ def __init__(
def execute(self, context: Context):
hook = GlacierHook(aws_conn_id=self.aws_conn_id)
return hook.retrieve_inventory(vault_name=self.vault_name)
+
+
+class GlacierUploadArchiveOperator(BaseOperator):
+ """
+ This operation adds an archive to a vault
+
+ .. seealso::
+ For more information on how to use this operator, take a look at the
guide:
+ :ref:`howto/operator:GlacierUploadArchiveOperator`
+
Review Comment:
Small nitpick, personal request/preference: I see you alphabetized the
docstring parameters, I usually put them in the same order they are declared in
the init() method sig. I don't know if there is a "standard" here or not.
Unless someone else chimes in to add more weight to this, consider it a
suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
