eladkal commented on code in PR #26652:
URL: https://github.com/apache/airflow/pull/26652#discussion_r1002051838
##########
airflow/providers/amazon/aws/operators/glacier.py:
##########
@@ -54,3 +54,55 @@ def __init__(
def execute(self, context: Context):
hook = GlacierHook(aws_conn_id=self.aws_conn_id)
return hook.retrieve_inventory(vault_name=self.vault_name)
+
+
+class GlacierUploadArchiveOperator(BaseOperator):
+ """
+ This operation adds an archive to a vault
+
+ .. seealso::
+ For more information on how to use this operator, take a look at the
guide:
+ :ref:`howto/operator:GlacierUploadArchiveOperator`
+
+ :param account_id: The AWS account ID of the account that owns the vault.
+ You can either specify an AWS account ID or optionally a single `-`
(hyphen),
+ in which case Amazon S3 Glacier uses the AWS account ID associated with
+ the credentials used to sign the request
+ :param vault_name: The name of the vault
+ :param body: A bytes or seekable file-like object. The data to upload.
Review Comment:
That is still transfer operator: LocalTo* we have several of those in the
project.
The issue is that operators don't share disk so the only valid case for
upload from disk without transfer operator is if the task you are running is
doing source to destination in single task (usually PythonOperator).
As I said I'm OK with adding this but I didn't see any real production case
usage for this kind of operators. If this is one and can be shown in an example
DAG I be happy to learn something new :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
