dstandish commented on code in PR #27197:
URL: https://github.com/apache/airflow/pull/27197#discussion_r1002643215
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -287,6 +275,12 @@ def __init__(
self.pod_request_obj: k8s.V1Pod | None = None
self.pod: k8s.V1Pod | None = None
+ if "resources" in kwargs:
Review Comment:
but i guess the idea was simply to catch that case you mentioned, when user
_thinks_ they are still supplying container requirements but they are instead
going to base operator. seems checking the obj type like this would cover that
case, while still allowing normal usage of `resources` -- whatever that is...
though maybe i'm missing some pieces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
