dstandish commented on code in PR #27197:
URL: https://github.com/apache/airflow/pull/27197#discussion_r1003564302
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -287,6 +275,12 @@ def __init__(
self.pod_request_obj: k8s.V1Pod | None = None
self.pod: k8s.V1Pod | None = None
+ if "resources" in kwargs:
Review Comment:
i really do think it's probably best to keep the same if but just raise
instead of warn (and not raise whenever resources passed)
1. it's kind of us to raise in this case because clearly user thinks they
are setting k8s resources but it's not gonna work anymore so we should
absolutely raise in this case
2. but it's unnecessary to raise _otherwise_ because, whether useless or
not, it's still a valid base operator param so really, there's no reason not to
allow it. remember that even with KPO, the task itself may run on celery (or
whatever executor) -- the "pod" will get the container_resources but the task
itself will not.
i realize, this is not of great consequence, and you have my approval
anyway, just calling it like i see it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
