gerardo commented on a change in pull request #4938: [AIRFLOW-4117]
Multi-staging Image - Travis CI tests [Step 3/3]
URL: https://github.com/apache/airflow/pull/4938#discussion_r298455846
##########
File path: docs/build.sh
##########
@@ -18,38 +18,74 @@
# specific language governing permissions and limitations
# under the License.
-set -e
+set -euo pipefail
-FWDIR="$(cd "`dirname "$0"`"; pwd)"
-cd "$FWDIR"
+MY_DIR="$(cd "`dirname "$0"`"; pwd)"
+pushd "${MY_DIR}" || exit 1
-NUM_INCORRECT_USE_LITERALINCLUDE_DIRECTIVE=$(grep -inR --include \*.rst
'literalinclude::.\+example_dags' .\
- tee /dev/tty |\
+if [[ ${APT_DEPS_IMAGE:=""} != "" ]]; then
+ # We are inside the container which means that we should fix permissions
of the _build folder files
+ # Those files are mounted from the host!
+ echo "Changing ownership of docs/_build folder to
${AIRFLOW_USER}:${AIRFLOW_USER}"
+ sudo chown ${AIRFLOW_USER}:${AIRFLOW_USER} _build
+ echo "Changed ownership of docs/_build folder to
${AIRFLOW_USER}:${AIRFLOW_USER}"
Review comment:
Not a problem really, just a pet peeve: Having 2 echo lines for every
command that gets executed (`Changing`/ `Changed`, `Removing`/`Removed`) is
probably unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
