gerardo commented on a change in pull request #4938: [AIRFLOW-4117]
Multi-staging Image - Travis CI tests [Step 3/3]
URL: https://github.com/apache/airflow/pull/4938#discussion_r298456378
##########
File path: hooks/build
##########
@@ -263,18 +309,23 @@ if [[ "${AIRFLOW_CONTAINER_USE_PULLED_IMAGES_CACHE}" ==
"true" ]]; then
echo
echo
if [[ "${AIRFLOW_CONTAINER_FORCE_PULL_IMAGES}" == "true" ]]; then
- echo "Force-pull base python image. This forces to get the latest
version."
+ echo "Force-pull base python image. This forces to get the most recent
versions from the repository."
echo
set -x
docker pull "${PYTHON_BASE_IMAGE}"
set +x
echo
fi
- IMAGES_TO_PULL="${AIRFLOW_CI_IMAGE}"
- if [[ "${AIRFLOW_CONTAINER_SKIP_MAIN_IMAGE}" == "true" ]]; then
- echo "Skip downloading the main Airflow image"
+ IMAGES_TO_PULL=""
+ if [[ "${AIRFLOW_CONTAINER_SKIP_CI_IMAGE}" == "true" ]]; then
+ echo "Skip downloading the CI Airflow image"
else
- IMAGES_TO_PULL="${IMAGES_TO_PULL} ${AIRFLOW_IMAGE}"
+ IMAGES_TO_PULL="${IMAGES_TO_PULL} ${AIRFLOW_CI_IMAGE}"
+ fi
+ if [[ "${AIRFLOW_CONTAINER_SKIP_SLIM_CI_IMAGE}" == "true" ]]; then
+ echo "Skip downloading the slim Airflow image"
+ else
+ IMAGES_TO_PULL="${IMAGES_TO_PULL} ${AIRFLOW_SLIM_CI_IMAGE}"
Review comment:
Where is `IMAGES_TO_PULL` being used? I can't find another place where the
variable is being used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
