dstandish commented on code in PR #27197:
URL: https://github.com/apache/airflow/pull/27197#discussion_r1008329617
##########
airflow/providers/cncf/kubernetes/backcompat/backwards_compat_converters.py:
##########
@@ -62,20 +62,6 @@ def convert_volume_mount(volume_mount) -> k8s.V1VolumeMount:
return _convert_kube_model_object(volume_mount, k8s.V1VolumeMount)
-def convert_resources(resources) -> k8s.V1ResourceRequirements:
- """
- Converts an airflow Resources object into a k8s.V1ResourceRequirements
-
- :param resources:
- :return: k8s.V1ResourceRequirements
- """
- if isinstance(resources, dict):
- from airflow.providers.cncf.kubernetes.backcompat.pod import Resources
Review Comment:
should we also remove this module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
