uranusjr commented on code in PR #27381:
URL: https://github.com/apache/airflow/pull/27381#discussion_r1011362866
##########
airflow/jobs/local_task_job.py:
##########
@@ -161,6 +191,10 @@ def handle_task_exit(self, return_code: int) -> None:
"""
# Without setting this, heartbeat may get us
self.terminating = True
+
+ if abs(return_code) == signal.SIGSEGV: # Handle signal.SIGSEGV and
psutil._psposix.Negsignal.SIGSEGV
Review Comment:
Why the `abs`? Positive and negative return codes are different values. If
you want to remove trash bits over 256 you need a bit mask instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
