Taragolis commented on code in PR #27381:
URL: https://github.com/apache/airflow/pull/27381#discussion_r1012737543
##########
airflow/jobs/local_task_job.py:
##########
@@ -161,6 +191,10 @@ def handle_task_exit(self, return_code: int) -> None:
"""
# Without setting this, heartbeat may get us
self.terminating = True
+
+ if abs(return_code) == signal.SIGSEGV: # Handle signal.SIGSEGV and
psutil._psposix.Negsignal.SIGSEGV
Review Comment:
Oh... I'm understand that I mix up kill signals (SIGSEGV = 11) and
return_code which, I thought, depends on `task_runner` and for default
`StandardTaskRunner` return code when task failed with Segmentation Fault in
this case -11 and might be different for CgroupTaskRunner (I assume that 139
but need to check)
So might be better move this log message from
`airflow/jobs/local_task_job.pyy` to a
`airflow/task/task_runner/standard_task_runner.py` and
`airflow/task/task_runner/cgroup_task_runner.py`? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
