dstandish commented on code in PR #27428: URL: https://github.com/apache/airflow/pull/27428#discussion_r1013254458
########## airflow/api_connexion/schemas/task_instance_schema.py: ########## @@ -33,6 +33,14 @@ from airflow.utils.state import State +class _ExecutorConfigField(fields.String): + def _serialize(self, value, attr, obj, **kwargs): + try: + return super()._serialize(value, attr, obj, **kwargs) + except Exception: Review Comment: @uranusjr curious what's problematic with being very broad.... the goal i guess is to not fail the whole request just because one field fails to serialize...? ########## airflow/api_connexion/schemas/task_instance_schema.py: ########## @@ -33,6 +33,14 @@ from airflow.utils.state import State +class _ExecutorConfigField(fields.String): + def _serialize(self, value, attr, obj, **kwargs): + try: + return super()._serialize(value, attr, obj, **kwargs) + except Exception: Review Comment: @uranusjr curious what's problematic with being very broad.... the goal i guess is to not fail the whole request just because one field fails to serialize. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
