tirkarthi commented on PR #27428: URL: https://github.com/apache/airflow/pull/27428#issuecomment-1301731612
> i think instead of implementing _super_serialize you can just create a TI with a bad executor config. then you don't need to mock the super class. (and don't need to implement that method either) > would also be great to have a test verifying that a good executor config is [still] serialized correctly Thanks, added test where `__str__` raises Exception and also a test with dict for serialization. Regarding `get_attribute`, from the docs it seems this method is for retrieving the value so serialization for the value might still fail. https://marshmallow.readthedocs.io/en/stable/api_reference.html#marshmallow.Schema.get_attribute -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
