eladkal commented on code in PR #27502:
URL: https://github.com/apache/airflow/pull/27502#discussion_r1014009585
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -267,7 +267,7 @@ def consume_logs(*, since_time: DateTime | None = None,
follow: bool = True) ->
time.sleep(1)
def await_container_completion(self, pod: V1Pod, container_name: str) ->
None:
- while not self.container_is_running(pod=pod,
container_name=container_name):
+ while self.container_is_running(pod=pod,
container_name=container_name):
Review Comment:
same fix was suggest and merged in
https://github.com/apache/airflow/pull/23883 but It was reverted in
https://github.com/apache/airflow/pull/24479
so just trying the same thing again is probably not going to work?
cc @akakakakakaa as the original author
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
