windmark commented on code in PR #27502:
URL: https://github.com/apache/airflow/pull/27502#discussion_r1014086106
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -267,7 +267,7 @@ def consume_logs(*, since_time: DateTime | None = None,
follow: bool = True) ->
time.sleep(1)
def await_container_completion(self, pod: V1Pod, container_name: str) ->
None:
- while not self.container_is_running(pod=pod,
container_name=container_name):
+ while self.container_is_running(pod=pod,
container_name=container_name):
Review Comment:
Hi, thanks, yeah I'm aware. I opened this PR as a Draft (but wasn't aware
that still pinged anyone) to see if I could run the CI tests.
The original PR was reverted due to failing tests, but unfortunately the CI
logs and the slack conversations have both fallen victim to the retention. I'm
still figuring out the testing flow locally but haven't found any failing tests
yet, so must be missing something (as a new contributor).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
