jedcunningham commented on code in PR #27495:
URL: https://github.com/apache/airflow/pull/27495#discussion_r1014223468
##########
airflow/providers/microsoft/azure/log/wasb_task_handler.py:
##########
@@ -62,7 +60,7 @@ def hook(self):
from airflow.providers.microsoft.azure.hooks.wasb import WasbHook
return WasbHook(remote_conn_id)
- except AzureHttpError:
+ except Exception:
Review Comment:
I don't see what's AzureHttpError specific about the error message? Maybe
propose what you'd like to see instead.
##########
airflow/providers/microsoft/azure/log/wasb_task_handler.py:
##########
@@ -62,7 +60,7 @@ def hook(self):
from airflow.providers.microsoft.azure.hooks.wasb import WasbHook
return WasbHook(remote_conn_id)
- except AzureHttpError:
+ except Exception:
self.log.exception(
'Could not create an WasbHook with connection id "%s".'
Review Comment:
```suggestion
'Could not create a WasbHook with connection id "%s".'
```
##########
airflow/providers/microsoft/azure/log/wasb_task_handler.py:
##########
@@ -62,7 +60,7 @@ def hook(self):
from airflow.providers.microsoft.azure.hooks.wasb import WasbHook
return WasbHook(remote_conn_id)
- except AzureHttpError:
+ except Exception:
self.log.exception(
'Could not create an WasbHook with connection id "%s".'
Review Comment:
Might as well fix up grammar while we are here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
