dstandish commented on code in PR #27495:
URL: https://github.com/apache/airflow/pull/27495#discussion_r1014408662
##########
airflow/providers/microsoft/azure/log/wasb_task_handler.py:
##########
@@ -62,7 +60,7 @@ def hook(self):
from airflow.providers.microsoft.azure.hooks.wasb import WasbHook
return WasbHook(remote_conn_id)
- except AzureHttpError:
+ except Exception:
Review Comment:
OK so... maybe everybody can be happy with this
I have phrased it less conclusively. Making it more clear that these are
just suggestions to look into. It was never the case that, were we to find
ourselves in this except block, that provider wasn't installed (how is this
code running in that case? maybe installed from sources???) or connection not
there (that wouldn't even make it to this block before because it is
AirflowNotFoundException). Now it actually could be missing connection (since
we have the broader except). So the suggestion is actually better as a result
of this change. Meanwhile, the provider not installed theory is ... at
least... no _less_ bad..... In any case they are just questions and not
statements of fact, so I feel ok with this now.
Thanks for your help in reviewing, and let me know if any further concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
