uranusjr commented on code in PR #27524:
URL: https://github.com/apache/airflow/pull/27524#discussion_r1015178454
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -62,6 +62,23 @@
from airflow.utils.context import Context
+def _task_id_to_pod_name(val):
+ val = val.lower()
+ first = val[0]
+ if not re.match(r"[a-z0-9]", first):
+ val = "0" + val
+ last = val[-1]
+ if not re.match(r"[a-z0-9]", last):
+ val = val + "0"
+ val = re.sub(r"[^a-z0-9\-.]", "-", val)
+ if len(val) > 253:
+ raise ValueError(
+ f"Pod name {val} is longer than 253 characters. "
+ "See
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/.";
+ )
+ return val
Review Comment:
We also already have `create_pod_id`. Should we use that or a variant of it
instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
