dstandish commented on code in PR #27524:
URL: https://github.com/apache/airflow/pull/27524#discussion_r1015782143
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -62,6 +62,23 @@
from airflow.utils.context import Context
+def _task_id_to_pod_name(val):
+ val = val.lower()
+ first = val[0]
+ if not re.match(r"[a-z0-9]", first):
+ val = "0" + val
+ last = val[-1]
+ if not re.match(r"[a-z0-9]", last):
+ val = val + "0"
+ val = re.sub(r"[^a-z0-9\-.]", "-", val)
+ if len(val) > 253:
Review Comment:
Another thing that's interesting....
I thought i was going to have a problem to deal with with random suffix.
Because what if task_id is 250 then suffix adds 30 characters?
Well it turns out that whenever the given "pod name" is longer than like 30
or 40 characters, adding pod suffix truncates the name and adds the suffix. So
when you enable suffix it's never longer than like 60 characters or something.
You can see this behavior in the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
