alanatlemba commented on code in PR #27457:
URL: https://github.com/apache/airflow/pull/27457#discussion_r1016143255
##########
tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py:
##########
@@ -97,6 +97,53 @@ def setup(self, dag_maker):
patch.stopall()
+ def test_template_fields(self):
+ assert 9 == KubernetesPodOperator.template_fields.__len__()
+ KubernetesPodOperator.template_fields.__contains__('image')
+ KubernetesPodOperator.template_fields.__contains__('cmds')
+ KubernetesPodOperator.template_fields.__contains__('arguments')
+ KubernetesPodOperator.template_fields.__contains__('env_vars')
+ KubernetesPodOperator.template_fields.__contains__('labels')
+ KubernetesPodOperator.template_fields.__contains__('config_file')
+ KubernetesPodOperator.template_fields.__contains__('pod_template_file')
+ KubernetesPodOperator.template_fields.__contains__('namespace')
+
KubernetesPodOperator.template_fields.__contains__('container_resources')
Review Comment:
Hi @uranusjr. After reviewing, I tend to agree, but do not feel strongly
about it.
I kept it in since it had been in https://github.com/nitinmuteja original PR
and no one had brought anything up about it.
https://github.com/apache/airflow/pull/23531/files#diff-9eab8bfed52232ef1125033c59024d9ed878b6504b830ba633aa2ad7d1f60151
This PR (and its prior one) have been cooking for 2-3 weeks now and finally
has been approved. I can go ahead and remove these if need be, but would
prefer (and commit) to doing a follow up PR to remove this if folks feel
strongly about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
