jedcunningham commented on code in PR #27611:
URL: https://github.com/apache/airflow/pull/27611#discussion_r1019721454


##########
airflow/executors/kubernetes_executor.py:
##########
@@ -646,6 +649,14 @@ def sync(self) -> None:
                             json.loads(e.body)["message"],
                         )
                         self.task_queue.put(task)
+                except PodMutationHookException as e:
+                    key, _, _, _ = task
+                    self.log.warning(
+                        'Pod Mutation Hook failed for the task %s. 
Re-queueing. Details: %s',

Review Comment:
   I feel like we should fail it instead. It could just as easily always fail 
and end up stuck, probably better to rely on retries to give it another chance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to