jedcunningham commented on code in PR #27611:
URL: https://github.com/apache/airflow/pull/27611#discussion_r1019728052
##########
airflow/executors/kubernetes_executor.py:
##########
@@ -646,6 +649,14 @@ def sync(self) -> None:
json.loads(e.body)["message"],
)
self.task_queue.put(task)
+ except PodMutationHookException as e:
+ key, _, _, _ = task
+ self.log.warning(
+ 'Pod Mutation Hook failed for the task %s.
Re-queueing. Details: %s',
Review Comment:
The k8s logic at least tries to differentiate between "probably always
fatal" and "probably not always fatal" errors. Not sure we can easily do that
with the mutation hook though, so taking the "safe" path of failing makes the
most sense to me.
Said another way, I have no problem requeuing if we only try it when we
think it might succeed the next time instead of having blind confidence it'll
eventually work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
