uranusjr commented on code in PR #26658:
URL: https://github.com/apache/airflow/pull/26658#discussion_r1021027532
##########
airflow/www/views.py:
##########
@@ -1966,6 +1966,7 @@ def trigger(self, session=None):
flash(f"Triggered {dag_id}, it should start any moment now.")
return redirect(origin)
+ @provide_session
Review Comment:
Since this is an internal function, we should be able to control all cases
where `session` is needed, and explicitly pass it. This decorator is thus
redundant and should be removed.
Also, can we take this change to add type hints to all arguments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
