potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r299358683
########## File path: docs/build.sh ########## @@ -18,38 +18,74 @@ # specific language governing permissions and limitations # under the License. -set -e +set -euo pipefail -FWDIR="$(cd "`dirname "$0"`"; pwd)" -cd "$FWDIR" +MY_DIR="$(cd "`dirname "$0"`"; pwd)" Review comment: Ah yeah. I would like to keep it to a separate PR. I already fixed a lot of SHELL problems by running shellcheck (part of the auto-commit changes). I will send a bunch (maybe 40) of other small PRs including pylint fixes and shell fixes, and xml fixes and tab removals etc - but I think they should be separate from that one. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
