potiuk commented on a change in pull request #4938: [AIRFLOW-4117]
Multi-staging Image - Travis CI tests [Step 3/3]
URL: https://github.com/apache/airflow/pull/4938#discussion_r299361443
##########
File path:
airflow/migrations/versions/004c1210f153_increase_queue_name_size_limit.py
##########
@@ -40,7 +40,7 @@ def upgrade():
by broker backends that might use unusually large queue names.
"""
# use batch_alter_table to support SQLite workaround
- with op.batch_alter_table('task_instance') as batch_op:
+ with op.batch_alter_table('task_instance') as batch_op: #
pylint:disable=no-member
Review comment:
When I switched pylint to use docker image - that problem started to show up
in Travis. Seems to come up with the way pylint was run in the non-contenerised
version - skipping migrations. I think it's good to keep this fix so that we
have green CI. One of my unrelated changes that I am going to submit soon is to
disable some pylint checks on migrations. But it would be great to merge this
one so that we have consistent environment for pylint checks. It was one of the
problems so far that different environments produced different set of pylint
errors. By implementing this change we will have one environment for both -
local and CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
