mlnsharma commented on PR #27802: URL: https://github.com/apache/airflow/pull/27802#issuecomment-1321568374
Thanks @bdsoha @XD-DENG @pulquero for your comments. I will fix the double quotes, test failures. Regarding the backward compatibility. Do you all agree with the below solution: - 'log_containers' will be a new parameter in KubernetesPodOperator of type string array, with the default value being ['base']. This will work only if 'get_logs=True' is passed. If the 'log_containers' value is passed as any empty array [], then all containers excluding airflow-xcom-sidecar container logs will be displayed. If the value contains any other set of container names, all those container logs will only be captured. This new param will also be added to documentation. - Since Airflow defaults the name of the first container to 'base', if the 'log_containers' param value consists of the actual name provided in the 'pod_template_file', all the 'log_containers' names will be checked against the actual container names in the pod. If a container name is not present in the actual pod, it will be treated as the 'base' container. Please let me know your thoughts on the param name and any of the above statements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
