bolkedebruin commented on PR #27826: URL: https://github.com/apache/airflow/pull/27826#issuecomment-1323314423
It was added in https://github.com/apache/airflow/pull/19965 . That's just 11 months ago, but I havent figured out what release. So it is the choice of going through possibly a bit of pain for some if they made use of this functionality (which wasn't standard before. It is interesting that we just implemented it as it was a change of behavior before that!) or to go through a whole deprecation cycle. It is not backwards compatible in any case. In other words if you want to retain the old behavior you will need to update your DAGs. I do think the impact is relatively low and we should change it asap before it gets more widespread. It requires `typing` which isn't truly integrated with everyone's workflow (heck we arent even consistent ourselves in our examples) and it requires the type to be `dict`. So it does **not** do `every annotation` which you seemed to imply above. So I see three options: 1) Remove outright in 2.5 (preferred imho, lowish impact on integrity easily fixed) 2) Break on detecting `dict` and no explicit value for `multiple_outputs`, remove later (better on integrity) 3) Deprecation cycle: log warning and remove later (long cycle, what is real benefit?) Typically I would opt for 3 for a large change, 2 for a change that is easy to fix but with some impact and 1) if little impact. My assessment is little impact so I would opt for 1, but maybe 2 is better. cc @ashb wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
