bolkedebruin commented on code in PR #27826:
URL: https://github.com/apache/airflow/pull/27826#discussion_r1030119245
##########
airflow/decorators/base.py:
##########
@@ -300,6 +300,10 @@ def _infer_multiple_outputs(self):
except TypeError: # Can't evaluate return type.
return False
ttype = getattr(return_type, "__origin__", return_type)
+ if ttype == dict or ttype == Dict:
+ raise AttributeError(
+ "multiple_outputs was not set and will not implicitly unroll
dict for return values"
+ )
Review Comment:
I think it is an AttributeError. An attribute `multiple_outputs` is an
attribute and was not set so we don't what to do. An AirflowException is very
generic.
If we are going for option 2 I don't think the DAG should parse and in that
case I think the error message should not refer to the old behavior as that
implies knowing what that is. What you are describing seems more like a
deprecation warning though and thus option 3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
