Taragolis commented on PR #27823: URL: https://github.com/apache/airflow/pull/27823#issuecomment-1323920887
This is my personal thoughts 1. Someone of end users might be unhappy the fact that we actually started collect additional telemetry like. dag_id and ClassName even if it only hashes. So might be better collect by default only Airflow and Amazon Provider version and if required additional metadata then call optional callable which could controlled by config e.g. `[aws] extra_botocore_user_agent_callable` with full qualified path to callable e.g. `some_vendor.safe.get_user_agent` 2. I thought we also might add/merge config in AwsCredentialHelper rather than in hook https://github.com/apache/airflow/blob/093345cb61cea623bffe6af5a41d6ba417dfcf6f/airflow/providers/amazon/aws/utils/connection_wrapper.py#L229-L235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
