Taragolis commented on code in PR #27823:
URL: https://github.com/apache/airflow/pull/27823#discussion_r1029794228
##########
airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -25,9 +25,13 @@
from __future__ import annotations
Review Comment:
About calling method/function I mean something like that (just simplified
version)
```python
from airflow.configuration import conf
def user_agent() -> dict:
# Construct some generic part, like airflow version and provider version
ua = {
"airflow": "3.0.0",
"amazon-provider": "15.0.0"
}
fn = conf.getimport("aws", "extra_botocore_user_agent_callable",
fallback=None)
if fn and callable(fn):
# Vendor user-agent
ua.update(fn())
return ua
```
Something similar that snowflake provider has
https://github.com/apache/airflow/blob/035315f5cf331a0fc5b1800f708e2f83fcfb2d7a/airflow/providers/snowflake/hooks/snowflake.py#L233-L234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
