dstandish commented on code in PR #27849:
URL: https://github.com/apache/airflow/pull/27849#discussion_r1030743462
##########
airflow/www/views.py:
##########
@@ -263,19 +263,20 @@ def dag_to_grid(dag, dag_runs, session):
TaskInstance.task_id,
TaskInstance.run_id,
TaskInstance.state,
- TaskInstance.notes,
- sqla.func.count(sqla.func.coalesce(TaskInstance.state,
sqla.literal("no_status"))).label(
+ func.min(TaskInstanceNote.content).label("notes"),
Review Comment:
so...
yes it's always weird when you see this but there's a reason
some dbs have `any_value` or `first`. that would make more sense here. but
sqla no have this. `min` is proxy for "just give me something"
the alternative is what was there before, which is adding to the group by.
but that doesn't make much sense either (i asked brent, he said we don't need
to be creating new groups based on the presence of notes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
