dstandish commented on code in PR #27849:
URL: https://github.com/apache/airflow/pull/27849#discussion_r1030747635
##########
tests/api_connexion/endpoints/test_task_instance_endpoint.py:
##########
@@ -380,18 +380,13 @@ def
test_should_respond_200_task_instance_with_sla_and_rendered(self, session):
def test_should_respond_200_mapped_task_instance_with_rtif(self, session):
"""Verify we don't duplicate rows through join to RTIF"""
tis = self.create_task_instances(session)
- session.query()
- ti = tis[0]
- ti.map_index = 1
Review Comment:
the issue that forced the simplification...
what the code was doing is this...
> we need a few mapped ti, so let's take existing ti, notes and all, and
change the map index
but now that notes is diff table, you can't just change the map index of ti
because that won't also change the index of the keyed obj, namely notes.
simpler to just create _new_ ti.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
