Taragolis commented on PR #27796:
URL: https://github.com/apache/airflow/pull/27796#issuecomment-1325600338

   @potiuk @uranusjr Just wondering is 
`airflow.models.connection.Connection.get_uri()` intend to return valid 
SQLAlchemy URI? Might be I wrong but I thought this method only use for 
generate Airflow Connection URI.
   
   And we could be in a situation if user generate Airflow Connection URI for 
PostgreSQL and try to reuse it, e.g. as environment variable than 
common-sql-provider operators might not work because hook register with 
`postgres` conn_type not as `postgresql`
   
   And as far as I know `PostgresHook` has own method
   
https://github.com/apache/airflow/blob/fb7c6afc8cb7f93909bd2e654ea185eb6abcc1ea/airflow/providers/postgres/hooks/postgres.py#L170-L178
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to