potiuk commented on PR #27796: URL: https://github.com/apache/airflow/pull/27796#issuecomment-1325706646
> And we could be in a situation if user generate Airflow Connection URI for PostgreSQL and try to reuse it, e.g. as environment variable than common-sql-provider operators might not work because hook register with `postgres` conn_type not as `postgresql` @Taragolis - I think you are right. I was hesitating a bit before approving that one (for that very reason) - but I could not figure out a case where this could go wrong, so I figured that is OK to get it in. There were few people trying to do the same and reported similar issue, so I figured that we should be ok to do that (even though it was a bit strange to implement postgresl-specific thing in BaseHook. And yeah, that changes my "approval" vote for that scenario. @andersbogsnes I think that would be interesting to see why in this case you cannot use PostgresHook's method - and why you expect to have valid SQLAlchemy URL here (which is different than Airflow URL).. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
