eladkal commented on code in PR #27917:
URL: https://github.com/apache/airflow/pull/27917#discussion_r1032945171
##########
airflow/providers/amazon/aws/hooks/athena.py:
##########
@@ -91,8 +91,11 @@ def run_query(
}
if client_request_token:
params["ClientRequestToken"] = client_request_token
+ self.log.info("Running query_context:%s, query:\n%s", query_context,
query)
Review Comment:
logging query should be optional.
We had complains/problems about this before... for example:
https://github.com/apache/airflow/issues/11618
Thus in DbAPIHook we have:
https://github.com/apache/airflow/blob/2242ea4ec1e48278d7b65bf2dfda8151c912546d/airflow/providers/common/sql/hooks/sql.py#L112
We should avoid automatically logging things that other users might find
disrupting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
