dstandish commented on code in PR #27845:
URL: https://github.com/apache/airflow/pull/27845#discussion_r1035553932
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -650,6 +652,8 @@ class _suppress(AbstractContextManager):
The caught exception is also stored on the context manager instance under
attribute ``exception``.
+
+ :meta private:
Review Comment:
not _needed_ of course, but i think the separation of concerns is helpful.
we could define _suppress inside of _optionally_suppress, but... it's already
tested this way so... why bother? and it's private so it's not increasing
backcompat surface area i.e. doesn't really hurt to leave it there IMO. but
you tell me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
