dstandish commented on code in PR #27845:
URL: https://github.com/apache/airflow/pull/27845#discussion_r1036786509
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -650,6 +652,8 @@ class _suppress(AbstractContextManager):
The caught exception is also stored on the context manager instance under
attribute ``exception``.
+
+ :meta private:
Review Comment:
yeah so ... it's just ... one is "suppress with logging" (with otherwise
identical semantics to stdlib suppress) the other is "conditionally use ...
suppress with logging" which seemed to me nice from perspective of
intelligibility. rather than mashing into one where, it's entirely diff from
stdlib and harder to understand what it's doing.
ALAS, i have merged them, and added a test or two
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
