potiuk commented on code in PR #28006:
URL: https://github.com/apache/airflow/pull/28006#discussion_r1036332485
##########
airflow/providers/snowflake/hooks/snowflake.py:
##########
@@ -369,15 +369,19 @@ def run(
with closing(self.get_conn()) as conn:
self.set_autocommit(conn, autocommit)
- # SnowflakeCursor does not extend ContextManager, so we have to
ignore mypy error here
- with closing(conn.cursor(DictCursor)) as cur: # type:
ignore[type-var]
Review Comment:
Correct. This is breaking. I proposed to make Hook breaking change while
leaving Operators interface intact (I build the dicationary later). This is the
final price (one-time) to pay We already have a breaking change of Snowflake
provider and I want to yank 4.0.0 and 4.0.1 and make it even more breaking (it
is anyhow broken now for SqlCheck ad SqlColumnCheck and likely other places.
See more reasoning here
https://github.com/apache/airflow/issues/27976#issuecomment-1331514882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
