dstandish commented on code in PR #28006:
URL: https://github.com/apache/airflow/pull/28006#discussion_r1036378663
##########
airflow/providers/snowflake/hooks/snowflake.py:
##########
@@ -369,15 +369,19 @@ def run(
with closing(self.get_conn()) as conn:
self.set_autocommit(conn, autocommit)
- # SnowflakeCursor does not extend ContextManager, so we have to
ignore mypy error here
- with closing(conn.cursor(DictCursor)) as cur: # type:
ignore[type-var]
Review Comment:
What if the users prefer using DictCursor with the hook? Is it really
necessary to change that? It's a nice feature of the snowflake connector that
it provides such a cursor (and the flexibility to choose). Just because other,
older connectors don't have this option, why should snowflake conform?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
