dstandish commented on PR #28019: URL: https://github.com/apache/airflow/pull/28019#issuecomment-1332924717
> > There is an exception for type checking though, so if these are truly only for mypy... > > https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#dont-use-asserts-outside-tests > > Ah yeah. Forgot about it ... And I have not linked the CONTRIBUTING section 🤦 . Thanks @jedcunningham for that one. Refreshed my memory about it. Yeah so.... This is for type checking afaict Is it really necessary to add the if? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
