potiuk commented on PR #28019: URL: https://github.com/apache/airflow/pull/28019#issuecomment-1335958487
BTW. the if TYPE/assert is indeed much better in this case as it shows intention. The previous implementation (of old mine) tricked the future mine into thinking that it was somewhat possible to get into this flow. Funny thing is that In a way "just" assert wouldn't be as good as "if'd" one for similar reasons - it would not have clear indication that this assert is there only beacuse of MyPy. But now it's crystal clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
