pierrejeambrun commented on PR #27063: URL: https://github.com/apache/airflow/pull/27063#issuecomment-1336191334
To address your questions, (imho): - What you mentioned is I believe a good start to have something mergeable. (test, doc, etc.) - I believe this could make it in the next minor release -> 2.6.0 - Adding this feature via FAB is perfectly fine for me. AIP-38 is a long term ongoing work. At the moment I am not aware of a change that would bring the `trigger` page into 'react world' so we might have this under FAB for quite a while before it gets updated. - Part 2: We could fetch these forms on the `trigger.html` page, not before (dag level). And ask the person to chose which form/format he wants to use via extra buttons/select. (just an idea to not have to get all forms for all dags on the home page). - I know there has been a few questions about this behavior (slack) and we might benefit from updating it. Today I see it like this, a dag 'can' always run without config, this is what happens when it is not manually triggered. Manually triggering the dag without config would mimic a 'scheduled' run in terms of config i.e not using params 'at all'. Wondering what others think about this. Maybe the empty dict is misleading and a plain 'None' would be more appropriate. We woudn't want scheduled run to use default params values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
